From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 15 Aug 2019 02:12:50 +0000 Subject: Re: [PATCH] scsi: fnic: remove redundant assignment of variable rc Message-Id: List-Id: References: <20190813132349.8720-1-colin.king@canonical.com> In-Reply-To: <20190813132349.8720-1-colin.king@canonical.com> (Colin King's message of "Tue, 13 Aug 2019 14:23:49 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > Variable ret is initialized to a value that is never read and it is > re-assigned later and immediatetly returns. Clean up the code by > removing rc and just returning 0. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89240C433FF for ; Thu, 15 Aug 2019 02:13:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DC1F2084F for ; Thu, 15 Aug 2019 02:13:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GNXALDc1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729325AbfHOCNn (ORCPT ); Wed, 14 Aug 2019 22:13:43 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:55310 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfHOCNm (ORCPT ); Wed, 14 Aug 2019 22:13:42 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7F29jmk089665; Thu, 15 Aug 2019 02:13:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=1Lq/4W95GWvlW5TQd4bZ+yDCZ0W1oEysiFI+C3DWvqk=; b=GNXALDc163oQLCQJRmyqdSQRaqvWHnd6PwZAqM/MsFAWwequunBXggqPQ/pC66/R4Mnk vWy5priHjRG/I2Z7Wop02wGo6LjKkS409KU/u6zDnZQpFjhbRo+wzug7dQo0vgOzlRWz FtmzHXFDS2N3emjL75hr+toRwrx9AtW/9C29S+TiEl1W/IrLI1bmIoCTsWvSoIkEjKcm VQT4ozabvxRzEpKGIaXe7Rtf/DYahL+XKmo8yWYa+7oT98zIDzRz0K5ZreifU3iiEGRA QyaIBhcPogiUhm6hjJZD4ykQYY5zh6yJloty/z/+rrXU8/n4rHgvvCRFOMy/j8sWCXvn VA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2u9nbtr9e2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Aug 2019 02:13:37 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7F2DalT178710; Thu, 15 Aug 2019 02:13:37 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2ucmwj52yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Aug 2019 02:13:36 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7F2CuYF019400; Thu, 15 Aug 2019 02:12:56 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 14 Aug 2019 19:12:52 -0700 To: Colin King Cc: Satish Kharat , Sesidhar Baddela , Karan Tilak Kumar , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: fnic: remove redundant assignment of variable rc From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190813132349.8720-1-colin.king@canonical.com> Date: Wed, 14 Aug 2019 22:12:50 -0400 In-Reply-To: <20190813132349.8720-1-colin.king@canonical.com> (Colin King's message of "Tue, 13 Aug 2019 14:23:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9349 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908150022 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9349 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=943 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908150022 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Colin, > Variable ret is initialized to a value that is never read and it is > re-assigned later and immediatetly returns. Clean up the code by > removing rc and just returning 0. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering