From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Lee Duncan <leeman.duncan@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
cleech@redhat.com, hare@suse.de, Lee Duncan <lduncan@suse.com>
Subject: Re: [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task
Date: Thu, 07 Mar 2019 21:38:04 -0500 [thread overview]
Message-ID: <yq14l8et7jn.fsf@oracle.com> (raw)
In-Reply-To: <20190225174130.29496-1-leeman.duncan@gmail.com> (Lee Duncan's message of "Mon, 25 Feb 2019 09:41:30 -0800")
Lee,
> If there is an error queueing an iscsi command in
> iscsi_queuecommand(), for example if the transport fails to take the
> command in sessuin->tt->xmit_task(), then the error path can call
> iscsi_complete_task() without first aquiring the back_lock as
> required. This can lead to things like ITT pool can get corrupt,
> resulting in duplicate ITTs being sent out.
>
> The solution is to hold the back_lock around iscsi_complete_task()
> calls, and to add a little commenting to help others understand when
> back_lock must be held.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-03-08 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 17:41 [PATCH v2] scsi:libiscsi: Hold back_lock when calling iscsi_complete_task Lee Duncan
2019-03-06 18:23 ` Chris Leech
2019-03-08 1:37 ` Lee Duncan
2019-03-08 1:48 ` Chris Leech
2019-03-08 2:38 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14l8et7jn.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=cleech@redhat.com \
--cc=hare@suse.de \
--cc=lduncan@suse.com \
--cc=leeman.duncan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.