From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Intel SCU Linux support <intel-linux-scu@intel.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency
Date: Wed, 02 May 2018 03:32:08 +0000 [thread overview]
Message-ID: <yq14ljq7mx3.fsf@oracle.com> (raw)
In-Reply-To: <20180425105843.8607-1-colin.king@canonical.com> (Colin King's message of "Wed, 25 Apr 2018 11:58:43 +0100")
Colin,
> The sanity check on u->in_connection_align_insertion_frequency is
> being performed twice and hence the first check can be removed since
> it is redundant. Cleans up cppcheck warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if'
> condition is always true.
Applied to 4.18/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Intel SCU Linux support <intel-linux-scu@intel.com>,
Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency
Date: Tue, 01 May 2018 23:32:08 -0400 [thread overview]
Message-ID: <yq14ljq7mx3.fsf@oracle.com> (raw)
In-Reply-To: <20180425105843.8607-1-colin.king@canonical.com> (Colin King's message of "Wed, 25 Apr 2018 11:58:43 +0100")
Colin,
> The sanity check on u->in_connection_align_insertion_frequency is
> being performed twice and hence the first check can be removed since
> it is redundant. Cleans up cppcheck warning:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if'
> condition is always true.
Applied to 4.18/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-05-02 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 10:58 [PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency Colin King
2018-04-25 10:58 ` Colin King
2018-05-02 3:32 ` Martin K. Petersen [this message]
2018-05-02 3:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14ljq7mx3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=artur.paszkiewicz@intel.com \
--cc=colin.king@canonical.com \
--cc=intel-linux-scu@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.