From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: linux-scsi@vger.kernel.org, Promise_Linux <Promise_Linux@promise.com>
Subject: Re: [dm-devel] QUEUE_FLAG_CLUSTER?
Date: Thu, 25 Nov 2010 10:21:43 -0500 [thread overview]
Message-ID: <yq14ob5o2d4.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <85ABFDC4641C4847BA6088F2982EFD8F049D4EB8@nonamew.ptu.promise.com> (Ed Lin's message of "Fri, 19 Nov 2010 17:24:14 -0800")
>>>>> "Ed" == "Ed Lin <- PTU" <ed.lin@promise.com>> writes:
Ed,
Ed> The dm already has function to adjust limits based on underlying
Ed> device limits. So, is it good to add the no_cluster setting to the
Ed> queue limits at the scsi side? For example, some code change like
Ed> the following?
We should never issue a command that does not adhere to the limits set
by the device driver. Upon inspection I agree this is busted and it's my
fault.
DM does not have a request_queue when stacking and as a result we ended
up with two entities tracking whether a device supports clustering or
not. And as it turns out the queue flag and the queue limits are not
always in agreement.
I've coded up a proper fix for this and will post a patch shortly. I'm
just running a bunch of tests to ensure we do the right thing...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-11-25 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 1:24 QUEUE_FLAG_CLUSTER? Ed Lin - PTU
2010-11-25 15:21 ` Martin K. Petersen [this message]
2010-11-25 16:35 ` block: Deprecate QUEUE_FLAG_CLUSTER and use queue_limits instead Martin K. Petersen
2010-11-25 18:43 ` Jens Axboe
2010-11-26 0:37 ` Martin K. Petersen
2010-11-26 2:28 ` Mike Snitzer
2010-11-26 2:53 ` Martin K. Petersen
2010-11-26 9:00 ` Jens Axboe
2010-12-01 18:43 ` Jens Axboe
2010-11-29 19:08 ` [dm-devel] QUEUE_FLAG_CLUSTER? Ed Lin - PTU
2010-11-30 18:40 ` Martin K. Petersen
2010-12-07 21:48 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq14ob5o2d4.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Promise_Linux@promise.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.