From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>, Janek Kotas <jank@cadence.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Can Guo <quic_cang@quicinc.com>,
Anjana Hari <quic_ahari@quicinc.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers
Date: Fri, 05 Apr 2024 21:09:06 -0400 [thread overview]
Message-ID: <yq15xwvs3fl.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com> (Andrew Halaney's message of "Fri, 29 Mar 2024 15:46:42 -0500")
Andrew,
> Please review with care as I'm not all that confident in this subject.
> UFS has a lot of mb() variants used, most with comments saying "ensure
> this takes effect before continuing". mb()'s aren't really the way to
> guarantee that, a read back is the best method.
Applied to 6.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-04-06 1:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 20:46 [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 01/11] scsi: ufs: qcom: Perform read back after writing reset bit Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 02/11] scsi: ufs: qcom: Perform read back after writing REG_UFS_SYS1CLK_1US Andrew Halaney
2024-04-02 4:45 ` Manivannan Sadhasivam
2024-03-29 20:46 ` [PATCH v5 03/11] scsi: ufs: qcom: Remove unnecessary mb() after writing testbus config Andrew Halaney
2024-04-02 4:46 ` Manivannan Sadhasivam
2024-03-29 20:46 ` [PATCH v5 04/11] scsi: ufs: qcom: Perform read back after writing unipro mode Andrew Halaney
2024-04-02 4:47 ` Manivannan Sadhasivam
2024-03-29 20:46 ` [PATCH v5 05/11] scsi: ufs: qcom: Perform read back after writing CGC enable Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 06/11] scsi: ufs: cdns-pltfrm: Perform read back after writing HCLKDIV Andrew Halaney
2024-03-29 21:47 ` Bart Van Assche
2024-03-29 20:46 ` [PATCH v5 07/11] scsi: ufs: core: Perform read back after writing UTP_TASK_REQ_LIST_BASE_H Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 08/11] scsi: ufs: core: Perform read back after disabling interrupts Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 09/11] scsi: ufs: core: Perform read back after disabling UIC_COMMAND_COMPL Andrew Halaney
2024-03-29 20:46 ` [PATCH v5 10/11] scsi: ufs: core: Remove unnecessary wmb() after ringing doorbell Andrew Halaney
2024-03-29 21:48 ` Bart Van Assche
2024-03-29 21:48 ` Bart Van Assche
2024-04-02 4:49 ` Manivannan Sadhasivam
2024-03-29 20:46 ` [PATCH v5 11/11] scsi: ufs: core: Remove unnecessary wmb() prior to writing run/stop regs Andrew Halaney
2024-03-29 21:49 ` Bart Van Assche
2024-03-29 21:49 ` Bart Van Assche
2024-04-02 4:49 ` Manivannan Sadhasivam
2024-04-06 1:09 ` Martin K. Petersen [this message]
2024-04-09 3:08 ` [PATCH v5 00/11] scsi: ufs: Remove overzealous memory barriers Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15xwvs3fl.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jank@cadence.com \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_ahari@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.