From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 4/4] scsi: ufs: hisi: fix ufs_hba_variant_ops passing Date: Wed, 06 Mar 2019 12:45:31 -0500 Message-ID: References: <20190304193917.702601-1-arnd@arndb.de> <20190304193917.702601-4-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190304193917.702601-4-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 4 Mar 2019 20:39:11 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Alim Akhtar , Avri Altman , Pedro Sousa , Wei Li , Subhash Jadavani , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Arnd, > Without CONFIG_OF, the of_match_node() helper does not evaluate > its argument, and the compiler warns about the unused variable: > > drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe': > drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev' [-Werror=unused-variable] Applied to 5.1/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering