Re: [PATCH 15/21] lpfc: Implement support for wire-only DIF devices

["Martin K. Petersen" <martin.petersen@oracle.com>]

>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:

>> This patch adds the ability to support auto-enablement of wire-only
>> DIF (DIF is generated on TX to target, stripped on RX; OS unaware DIF
>> in use) for a select set of devices. Currently, there is only 1
>> device vendor supported: 3PARdata. When the feature is enabled,
>> Inquiry commands are trapped, the vendor matched, and DIF enablement
>> checked. In 3Par's case, there's a vendor specific check to see if
>> the LUN supports DIF.  If supported, DIF will be enabled on a per-lun
>> basis.  The driver will trap READS/WRITEs from the OS, check for LUN
>> DIF enablement, and if set, turns on write-only DIF.

Christoph> NAK. We do support proper DIF, and anyone who wants it should
Christoph> enable the real thing.

Christoph> And even if we would want to support a hack like this we'd do
Christoph> it genericly an not in a driver.

Agree completely.

-- 
Martin K. Petersen	Oracle Linux Engineering