From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Cc: linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@suse.de>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Martin Peterson <martin.petersen@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
Joe Perches <joe@perches.com>,
Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>,
lkml <linux-kernel@vger.kernel.org>,
Li Zefan <lizf@cn.fujitsu.com>,
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Subject: Re: [PATCH 2/2 v2] scsi: add scsi trace core function and put trace points
Date: Tue, 02 Feb 2010 18:12:00 -0500 [thread overview]
Message-ID: <yq1636fqlkv.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <4B666181.7080200@jp.fujitsu.com> (Kei Tokunaga's message of "Mon, 01 Feb 2010 14:07:13 +0900")
>>>>> "Kei" == Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com> writes:
I'm traveling so I won't have time to look at this closely until next
week. However, this caught my eye:
+static const char *
+scsi_trace_varlen(struct trace_seq *p, unsigned char *cdb, int len)
+{
+ switch (SERVICE_ACTION(cdb)) {
+ case READ_32:
+ case WRITE_32:
+ /* if protection is enabled */
+ if (((cdb[10] >> 5) & 0x7) == 1)
+ return scsi_trace_rw32(p, cdb, len);
+ /* fall through */
+ default:
+ return scsi_trace_misc(p, cdb, len);
+ }
+}
It is not a requirement that a 32-byte READ/WRITE request must have
PROTECT set. So that if statement is bogus.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2010-02-02 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 4:55 [PATCH 0/2 v2] scsi: ftrace based scsi tracing feature Kei Tokunaga
2010-02-01 4:55 ` Kei Tokunaga
2010-02-01 5:05 ` [PATCH 1/2 v2] scsi: add __print_hex() to ftrace Kei Tokunaga
2010-02-01 5:05 ` Kei Tokunaga
2010-02-01 5:07 ` [PATCH 2/2 v2] scsi: add scsi trace core function and put trace points Kei Tokunaga
2010-02-01 5:07 ` Kei Tokunaga
2010-02-02 23:12 ` Martin K. Petersen [this message]
2010-02-03 5:55 ` Kei Tokunaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1636fqlkv.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=kusumi.tomohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tokunaga.keiich@jp.fujitsu.com \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.