From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bart Van Assche <bvanassche@acm.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives
Date: Mon, 06 Jan 2020 23:10:15 -0500 [thread overview]
Message-ID: <yq17e233o0o.fsf@oracle.com> (raw)
In-Reply-To: <20191219003256.GA28144@roeck-us.net> (Guenter Roeck's message of "Wed, 18 Dec 2019 16:32:57 -0800")
Hi Guenter!
>> - I still think sensor naming needs work. How and where are the
>> "drivetemp-scsi-8-140" names generated?
>>
> Quick one: In libsensors, outside the kernel. The naming is generic,
> along the line of <driver name>-<bus name>-<bus index>-<slot>.
I understand that there are sensors that may not have an obvious
associated topology and therefore necessitate coming up with a suitable
naming or enumeration scheme. But in this case we already have a
well-defined SCSI device name. Any particular reason you don't shift the
chip.addr back and print the H:C:T:L format that you used as input?
However arcane H:C:T:L may seem, I think that predictable naming would
make things a lot easier for users that need to identify which device
matches which sensor...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-01-07 4:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 17:45 [PATCH v2 0/1] Summary: hwmon driver for temperature sensors on SATA drives Guenter Roeck
2019-12-15 17:45 ` [PATCH v2] hwmon: Driver " Guenter Roeck
2019-12-19 0:15 ` Martin K. Petersen
2019-12-19 0:32 ` Guenter Roeck
2020-01-07 4:10 ` Martin K. Petersen [this message]
2020-01-07 13:00 ` Guenter Roeck
2020-01-08 1:29 ` Martin K. Petersen
2020-01-08 15:32 ` Guenter Roeck
2019-12-19 7:37 ` Guenter Roeck
2020-01-01 17:46 ` Guenter Roeck
2020-01-03 3:06 ` Martin K. Petersen
2020-01-08 1:12 ` Martin K. Petersen
2020-01-08 15:33 ` Guenter Roeck
2020-01-11 20:22 ` Guenter Roeck
2020-01-12 11:17 ` Gabriel C
2020-01-12 11:21 ` Linus Walleij
2020-01-12 12:02 ` Gabriel C
2020-01-12 12:07 ` Linus Walleij
2020-01-12 13:07 ` Guenter Roeck
2020-01-12 13:45 ` Gabriel C
2020-01-12 15:26 ` Guenter Roeck
2020-01-12 18:37 ` Gabriel C
2020-01-12 20:08 ` Guenter Roeck
2020-01-12 22:26 ` Gabriel C
2020-01-14 3:03 ` Martin K. Petersen
2020-01-14 5:20 ` Guenter Roeck
2020-01-16 4:12 ` Martin K. Petersen
2020-01-16 5:09 ` Guenter Roeck
2020-01-16 17:47 ` Guenter Roeck
2020-01-17 1:43 ` Martin K. Petersen
2020-01-17 3:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17e233o0o.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=cphealy@gmail.com \
--cc=jdelvare@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.