From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 08 Aug 2019 02:16:41 +0000 Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc Message-Id: List-Id: References: <20190731222214.15720-1-colin.king@canonical.com> In-Reply-To: <20190731222214.15720-1-colin.king@canonical.com> (Colin King's message of "Wed, 31 Jul 2019 23:22:14 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jack Wang , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > There are several occasions where variable rc is being initialized > with a value that is never read and error is being re-assigned a > little later on. Clean up the code by removing rc entirely and > just returning the return value from the call to pm8001_issue_ssp_tmf Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: pm80xx: remove redundant assignments to variable rc Date: Wed, 07 Aug 2019 22:16:41 -0400 Message-ID: References: <20190731222214.15720-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190731222214.15720-1-colin.king@canonical.com> (Colin King's message of "Wed, 31 Jul 2019 23:22:14 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: Jack Wang , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Colin, > There are several occasions where variable rc is being initialized > with a value that is never read and error is being re-assigned a > little later on. Clean up the code by removing rc entirely and > just returning the return value from the call to pm8001_issue_ssp_tmf Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering