From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [RFC PATCH] nvme-pci: Bounce buffer for interleaved metadata
Date: Tue, 27 Feb 2018 22:42:27 -0500 [thread overview]
Message-ID: <yq17eqx4w64.fsf@oracle.com> (raw)
In-Reply-To: <20180224000547.7252-1-keith.busch@intel.com> (Keith Busch's message of "Fri, 23 Feb 2018 17:05:47 -0700")
Keith,
> This patch will enable such formats by allocating a bounce buffer
> interleaving the block and metadata, copying the everythign into the
> buffer for writes, or from it for reads.
Blargh. My eyes are bleeding!
> I dislike this feature intensely. It is incredibly slow and enough
> memory overhead to make this not very useful for reclaim, but it's
> possible people will leave me alone if the Linux nvme driver
> accomodated this format.
*sigh*
> On the other hand, I get the impression some people requesting this
> may think their application will get to access the extended LBAs. The
> reality is the kernel owns the metadata, so I may just setting myself
> up to explain why "fdisk" still shows a 512b format instead of 520b...
The whole point of DIF (over using regular 520 or 528 byte sectors) was
to keep the logical block size at 512 and not deal with the PI in the
data buffers.
And the point of defining DIX was to avoid having to do what your patch
is doing.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-02-28 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 0:05 [RFC PATCH] nvme-pci: Bounce buffer for interleaved metadata Keith Busch
2018-02-25 17:30 ` Sagi Grimberg
2018-02-26 16:49 ` Keith Busch
2018-02-28 3:46 ` Martin K. Petersen
2018-03-01 9:22 ` Sagi Grimberg
2018-02-28 3:42 ` Martin K. Petersen [this message]
2018-02-28 16:35 ` Keith Busch
2018-02-28 16:37 ` Christoph Hellwig
2018-02-28 19:54 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17eqx4w64.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.