From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] mpt3sas: fix dma_addr_t casts Date: Mon, 06 Nov 2017 23:03:00 -0500 Message-ID: References: <20171106133540.506572-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171106133540.506572-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 6 Nov 2017 14:35:16 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , Tomas Henzl , Sreekanth Reddy , Hannes Reinecke , Romain Perier , James Bottomley , Bart Van Assche , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Arnd, > After taking a closer look, I found that the problem is that the new > code mixes up pointers and dma_addr_t values unnecessarily. > > This changes it to use the correct types consistently, which lets us > get rid of a lot of type casts in the process. I'm also renaming some > variables to avoid confusion between physical and dma address spaces > that are often distinct. Nice work! Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering