From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 12/23] sd: handle REQ_UNMAP Date: Thu, 30 Mar 2017 22:19:55 -0400 Message-ID: References: <20170323143341.31549-1-hch@lst.de> <20170323143341.31549-13-hch@lst.de> <1490719722.2573.8.camel@sandisk.com> <20170330090201.GD12015@lst.de> <20170330173020.GB24229@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170330173020.GB24229-jcswGhMUV9g@public.gmane.org> (hch-jcswGhMUV9g@public.gmane.org's message of "Thu, 30 Mar 2017 19:30:20 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: "hch@lst.de" Cc: "axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org" , "linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Martin K. Petersen" , "snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org" , "linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Bart Van Assche , "lars.ellenberg-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org" , "shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org" List-Id: dm-devel.ids "hch-jcswGhMUV9g@public.gmane.org" writes: > If you manually change the provisioning mode to WS10 on a device that > must use WRITE SAME (16) to be able to address all blocks you're already > screwed right now, and with this patch you can screw yourself through > the WRITE_ZEROES path in addition to the DISCARD path. Oh, I see. We only had the LBA sanity check in place for write same, not for discard. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: "hch\@lst.de" Cc: "Martin K. Petersen" , Bart Van Assche , "agk\@redhat.com" , "lars.ellenberg\@linbit.com" , "snitzer\@redhat.com" , "philipp.reisner\@linbit.com" , "axboe\@kernel.dk" , "shli\@kernel.org" , "linux-scsi\@vger.kernel.org" , "dm-devel\@redhat.com" , "drbd-dev\@lists.linbit.com" , "linux-block\@vger.kernel.org" , "linux-raid\@vger.kernel.org" Subject: Re: [PATCH 12/23] sd: handle REQ_UNMAP From: "Martin K. Petersen" References: <20170323143341.31549-1-hch@lst.de> <20170323143341.31549-13-hch@lst.de> <1490719722.2573.8.camel@sandisk.com> <20170330090201.GD12015@lst.de> <20170330173020.GB24229@lst.de> Date: Thu, 30 Mar 2017 22:19:55 -0400 In-Reply-To: <20170330173020.GB24229@lst.de> (hch@lst.de's message of "Thu, 30 Mar 2017 19:30:20 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain List-ID: "hch@lst.de" writes: > If you manually change the provisioning mode to WS10 on a device that > must use WRITE SAME (16) to be able to address all blocks you're already > screwed right now, and with this patch you can screw yourself through > the WRITE_ZEROES path in addition to the DISCARD path. Oh, I see. We only had the LBA sanity check in place for write same, not for discard. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by mail09.linbit.com (LINBIT Mail Daemon) with ESMTP id 54C45105645E for ; Fri, 31 Mar 2017 04:20:09 +0200 (CEST) To: "hch\@lst.de" From: "Martin K. Petersen" References: <20170323143341.31549-1-hch@lst.de> <20170323143341.31549-13-hch@lst.de> <1490719722.2573.8.camel@sandisk.com> <20170330090201.GD12015@lst.de> <20170330173020.GB24229@lst.de> Date: Thu, 30 Mar 2017 22:19:55 -0400 In-Reply-To: <20170330173020.GB24229@lst.de> (hch@lst.de's message of "Thu, 30 Mar 2017 19:30:20 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Cc: "axboe@kernel.dk" , "linux-raid@vger.kernel.org" , "Martin K. Petersen" , "snitzer@redhat.com" , "philipp.reisner@linbit.com" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , "linux-scsi@vger.kernel.org" , Bart Van Assche , "lars.ellenberg@linbit.com" , "shli@kernel.org" , "agk@redhat.com" , "drbd-dev@lists.linbit.com" Subject: Re: [Drbd-dev] [PATCH 12/23] sd: handle REQ_UNMAP List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , "hch@lst.de" writes: > If you manually change the provisioning mode to WS10 on a device that > must use WRITE SAME (16) to be able to address all blocks you're already > screwed right now, and with this patch you can screw yourself through > the WRITE_ZEROES path in addition to the DISCARD path. Oh, I see. We only had the LBA sanity check in place for write same, not for discard. -- Martin K. Petersen Oracle Linux Engineering