From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
agk@redhat.com, Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH] dm: add topology support
Date: Fri, 05 Jun 2009 00:33:01 -0400 [thread overview]
Message-ID: <yq17hzrl2pu.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1244059149-14279-1-git-send-email-snitzer@redhat.com> (Mike Snitzer's message of "Wed, 3 Jun 2009 15:59:09 -0400")
>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:
Mike,
+ if (blk_stack_limits(&ti->limits, &q->limits, 0) < 0)
+ DMWARN("%s: target device %s is misaligned",
+ dm_device_name(ti->table->md), bdevname(bdev, b));
I did some testing tonight. You're always passing offset 0 into the
stacking function so things are not working right. This argument should
contain the offset to the first (data) sector. So you want something
like get_start_sect(bdev) << 9 for the stacking to do its magic.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2009-06-05 4:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 19:59 [PATCH] dm: add topology support Mike Snitzer
2009-06-05 4:33 ` Martin K. Petersen [this message]
2009-06-05 14:21 ` Mike Snitzer
2009-06-05 19:34 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17hzrl2pu.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.