From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sagar Biradar <sagar.biradar@microchip.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
linux-scsi <linux-scsi@vger.kernel.org>, <stable@vger.kernel.org>,
"Brian King" <brking@linux.vnet.ibm.com>,
Don Brace <don.brace@microchip.com>,
"Raja VS" <raja.vs@microchip.com>,
Kumar Meiyappan <kumar.meiyappan@microchip.com>,
Abhinav Kuchibhotla <abhinav.kuchibhotla@microchip.com>,
Uday kumar Bagam <udaykumar.bagam@microchip.com>,
Advait Churi <advait.churi@microchip.com>
Subject: Re: [PATCH] scsi: pm8001: reject firmware update in fatal error state
Date: Thu, 14 May 2026 22:09:50 -0400 [thread overview]
Message-ID: <yq18q9l5sps.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20260416153757.414896-1-sagar.biradar@microchip.com> (Sagar Biradar's message of "Thu, 16 Apr 2026 15:37:57 +0000")
Sagar,
> pm8001_store_update_fw() allows a firmware update request even when
> the controller has already entered a fatal error state.
>
> Firmware update is not valid once the controller is in that state, and
> attempting it can lead to a call trace. Reject the request early by
> checking controller_fatal_error, set the firmware status to
> FAIL_PARAMETERS, and return -EINVAL.
Applied to 7.2/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2026-05-15 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 15:37 [PATCH] scsi: pm8001: reject firmware update in fatal error state Sagar Biradar
2026-05-15 2:09 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18q9l5sps.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abhinav.kuchibhotla@microchip.com \
--cc=advait.churi@microchip.com \
--cc=brking@linux.vnet.ibm.com \
--cc=don.brace@microchip.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kumar.meiyappan@microchip.com \
--cc=linux-scsi@vger.kernel.org \
--cc=raja.vs@microchip.com \
--cc=sagar.biradar@microchip.com \
--cc=stable@vger.kernel.org \
--cc=udaykumar.bagam@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.