From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context
Date: Mon, 19 Aug 2019 22:10:43 -0400 [thread overview]
Message-ID: <yq18srozivw.fsf@oracle.com> (raw)
In-Reply-To: <20190812083134.7033-1-huangfq.daxian@gmail.com> (Fuqian Huang's message of "Mon, 12 Aug 2019 16:31:34 +0800")
Fuqian,
> As spin_unlock_irq will enable interrupts.
> Function lpfc_findnode_rpi is called from
> lpfc_sli_abts_err_handler (./drivers/scsi/lpfc/lpfc_sli.c)
> <- lpfc_sli_async_event_handler
> <- lpfc_sli_process_unsol_iocb
> <- lpfc_sli_handle_fast_ring_event
> <- lpfc_sli_fp_intr_handler
> <- lpfc_sli_intr_handler
> and lpfc_sli_intr_handler is an interrupt handler.
> Interrupts are enabled in interrupt handler.
> Use spin_lock_irqsave/spin_unlock_irqrestore instead of spin_(un)lock_irq
> in IRQ context to avoid this.
Applied to 5.4/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-08-20 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 8:31 [PATCH] scsi: lpfc: use spin_lock_irqsave instead of spin_lock_irq in IRQ context Fuqian Huang
2019-08-16 18:29 ` James Smart
2019-08-20 2:10 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18srozivw.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=huangfq.daxian@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.