From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] scsi: myrs: avoid stack overflow warning Date: Mon, 05 Nov 2018 22:36:14 -0500 Message-ID: References: <20181102154426.1951776-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20181102154426.1951776-1-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 2 Nov 2018 16:44:13 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Arnd, > Putting a 1024 byte data structure on the stack is generally a bad idea. > On 32-bit systems, it also triggers a compile-time warning when building > with -Og: Applied to 4.20/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering