From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Smart <jsmart2021@gmail.com>
Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org,
Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH] lpfc: Correct MDS diag and nvmet configuration
Date: Thu, 23 Aug 2018 22:13:21 -0400 [thread overview]
Message-ID: <yq18t4wa4vy.fsf@oracle.com> (raw)
In-Reply-To: <20180816230405.14272-1-jsmart2021@gmail.com> (James Smart's message of "Thu, 16 Aug 2018 16:04:05 -0700")
James,
> A recent change added some MDS processing in the lpfc_drain_txq
> routine that relies on the fcp_wq being allocated. For nvmet operation
> the fcp_wq is not allocated because it can only be an nvme-target.
> When the original MDS support was added LS_MDS_LOOPBACK was defined
> wrong, (0x16) it should have been 0x10 (decimal value used for hex
> setting). This incorrect value allowed MDS_LOOPBACK to be set
> simultaneously with LS_NPIV_FAB_SUPPORTED, causing the driver to crash
> when it accesses the non-existent fcp_wq.
>
> Correct the bad value setting for LS_MDS_LOOPBACK.
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-08-24 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 23:04 [PATCH] lpfc: Correct MDS diag and nvmet configuration James Smart
2018-08-20 22:15 ` Ewan D. Milne
2018-08-24 2:13 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18t4wa4vy.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.