From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
target-devel@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org,
Nicholas Bellinger <nab@linux-iscsi.org>,
Sagi Grimberg <sagig@mellanox.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v3 2/5] lib: introduce crc_t10dif_update()
Date: Tue, 28 Apr 2015 19:07:30 -0400 [thread overview]
Message-ID: <yq18udbyhql.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1430242716.660.70.camel@schen9-desk2.jf.intel.com> (Tim Chen's message of "Tue, 28 Apr 2015 10:38:36 -0700")
>>>>> "Tim" == Tim Chen <tim.c.chen@linux.intel.com> writes:
Tim> There are a lot of duplicated code between crc_t10dif_update and
Tim> crc_t10dif. The only difference is for the update function we
Tim> import the crc value. I will prefer that we consolidate the code
Tim> into a local inline function that crc_t10dif_update and crc_t10dif
Tim> invoke to get rid of all the duplication.
I'm OK with that approach.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2015-04-28 23:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 14:33 [PATCH v3 0/5] target: Fix several problems related to T10-PI support Akinobu Mita
2015-04-25 14:33 ` [PATCH v3 1/5] target: ensure se_cmd->t_prot_sg is allocated when required Akinobu Mita
2015-04-26 9:26 ` Sagi Grimberg
2015-04-26 9:44 ` Sagi Grimberg
2015-04-27 12:57 ` Akinobu Mita
2015-04-27 15:08 ` Sagi Grimberg
2015-04-25 14:33 ` [PATCH v3 2/5] lib: introduce crc_t10dif_update() Akinobu Mita
2015-04-27 23:41 ` Martin K. Petersen
2015-04-28 17:38 ` Tim Chen
2015-04-28 23:07 ` Martin K. Petersen [this message]
2015-04-29 0:39 ` Akinobu Mita
2015-04-29 0:49 ` Herbert Xu
2015-04-29 16:07 ` Tim Chen
2015-04-25 14:33 ` [PATCH v3 3/5] target: handle odd SG mapping for data transfer memory Akinobu Mita
2015-04-26 10:07 ` Sagi Grimberg
2015-04-27 13:03 ` Akinobu Mita
2015-04-25 14:33 ` [PATCH v3 4/5] target: Fix sbc_dif_generate() and sbc_dif_verify() for WRITE SAME Akinobu Mita
2015-04-26 9:53 ` Sagi Grimberg
2015-04-27 12:58 ` Akinobu Mita
2015-04-25 14:33 ` [PATCH v3 5/5] target/file: enable WRITE SAME when protection info is enabled Akinobu Mita
2015-04-26 9:58 ` Sagi Grimberg
2015-04-27 13:02 ` Akinobu Mita
2015-04-26 10:33 ` [PATCH v3 0/5] target: Fix several problems related to T10-PI support Sagi Grimberg
2015-04-27 23:50 ` Martin K. Petersen
2015-04-28 10:22 ` Sagi Grimberg
2015-04-28 23:06 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq18udbyhql.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akinobu.mita@gmail.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.