From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Salomon Dushimirimana <salomondush@google.com>
Cc: James.Bottomley@hansenpartnership.com, bvanassche@acm.org,
dlemoal@kernel.org, ipylypiv@google.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, vishakhavc@google.com
Subject: Re: [PATCH v3] scsi: sd: fix sd shutdown to issue START STOP UNIT command appropriately
Date: Fri, 25 Jul 2025 09:06:29 -0400 [thread overview]
Message-ID: <yq1a54spghg.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20250724214520.112927-1-salomondush@google.com> (Salomon Dushimirimana's message of "Thu, 24 Jul 2025 21:45:20 +0000")
Salomon,
> Commit aa3998dbeb3a ("ata: libata-scsi: Disable scsi device
> manage_system_start_stop") enabled libata EH to manage device power
> mode trasitions for system suspend/resume and removed the flag from
> ata_scsi_dev_config. However, since the sd_shutdown() function still
> relies on the manage_system_start_stop flag, a spin-down command is
> not issued to the disk with command "echo 1 >
> /sys/block/sdb/device/delete"
Applied to 6.17/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2025-07-25 13:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 20:38 [PATCH] scsi: sd: fix sd shutdown to issue START STOP UNIT command appropriately Salomon Dushimirimana
2025-07-24 20:46 ` Bart Van Assche
2025-07-24 21:05 ` Salomon Dushimirimana
2025-07-24 21:21 ` [PATCH v2] " Salomon Dushimirimana
2025-07-24 21:45 ` [PATCH v3] " Salomon Dushimirimana
2025-07-25 10:49 ` Damien Le Moal
2025-07-25 13:06 ` Martin K. Petersen [this message]
2025-07-28 15:47 ` Bart Van Assche
2025-07-28 23:15 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a54spghg.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=ipylypiv@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=salomondush@google.com \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.