From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: George Kennedy <george.kennedy@oracle.com>
Cc: gregkh@linuxfoundation.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 linux-next] scsi: scsi_debug: fix type in min_t to avoid stack OOB
Date: Mon, 08 Nov 2021 23:03:57 -0500 [thread overview]
Message-ID: <yq1a6iekmap.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <1636125055-10909-1-git-send-email-george.kennedy@oracle.com> (George Kennedy's message of "Fri, 5 Nov 2021 10:10:55 -0500")
George,
> Change min_t() to use type "u32" instead of type "int" to avoid stack
> out of bounds. With min_t() type "int" the values get sign extended
> and the larger value gets used causing stack out of bounds.
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-11-09 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 15:10 [PATCH v3 linux-next] scsi: scsi_debug: fix type in min_t to avoid stack OOB George Kennedy
2021-11-06 0:20 ` Douglas Gilbert
2021-11-09 4:03 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a6iekmap.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=george.kennedy@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.