From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variable 'cur_state' Date: Wed, 29 May 2019 22:24:32 -0400 Message-ID: References: <20190525123821.16528-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190525123821.16528-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Sat, 25 May 2019 20:38:21 +0800") Sender: linux-kernel-owner@vger.kernel.org To: YueHaibing Cc: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, megaraidlinux.pdl@broadcom.com List-Id: linux-scsi@vger.kernel.org YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_transition_to_ready: > drivers/scsi/megaraid/megaraid_sas_base.c:3900:6: warning: variable cur_state set but not used [-Wunused-but-set-variable] Applied to 5.3/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D5EC28CC2 for ; Thu, 30 May 2019 02:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C85524436 for ; Thu, 30 May 2019 02:24:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="gPGFA504" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727360AbfE3CYp (ORCPT ); Wed, 29 May 2019 22:24:45 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:57866 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726498AbfE3CYp (ORCPT ); Wed, 29 May 2019 22:24:45 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2J2n8189689; Thu, 30 May 2019 02:24:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=ltlJWbWq1yZAkcVh+VmX07QxzEGmHnOwwphE6ieZ6jI=; b=gPGFA504uRaVHE0dNzjFOoSolFbg5cuV/ZI98vS9IGAopaRK5bzkn4XhBEPG4p+6zHEn lXHfwD8f9jcDu97WYnc72f6xf/EDEnYbmy6Ki2LMz98faaOgDcgYX2NuREa7zWTMM7cZ Euw+/2k5U+ZeVF4BlZbquBD0qBwIfHhCm7c7xDKrBSXalB1U7J0KqVEAmL7MXQcnCSYc gjEutJrmOLIrZuadILjo1Rzh2XKcvXiDrIyP3ltCuDIkhkE4S454Grtgm1C9sZzF8NrM 0DNxM9IyFHO/tcwB3kP4FDbMAYlpmfuHyBjoah7zDNVXRZx1g5VtN65L7NOcvGIj7aFj iA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2spw4tnd4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:24:36 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4U2NNcY159976; Thu, 30 May 2019 02:24:36 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2ss1fnt61u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 May 2019 02:24:36 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4U2OZef009158; Thu, 30 May 2019 02:24:35 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 19:24:34 -0700 To: YueHaibing Cc: , , , , , , , Subject: Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variable 'cur_state' From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190525123821.16528-1-yuehaibing@huawei.com> Date: Wed, 29 May 2019 22:24:32 -0400 In-Reply-To: <20190525123821.16528-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Sat, 25 May 2019 20:38:21 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=921 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300016 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9272 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=963 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905300016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org YueHaibing, > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/megaraid/megaraid_sas_base.c: In function megasas_transition_to_ready: > drivers/scsi/megaraid/megaraid_sas_base.c:3900:6: warning: variable cur_state set but not used [-Wunused-but-set-variable] Applied to 5.3/scsi-queue. Thanks. -- Martin K. Petersen Oracle Linux Engineering