From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
adilger@dilger.ca, hch@infradead.org, martin.petersen@oracle.com
Subject: Re: [PATCH 06/12] block: add helpers for setting/checking write hint validity
Date: Fri, 16 Jun 2017 12:47:42 -0400 [thread overview]
Message-ID: <yq1a857q3pt.fsf@oracle.com> (raw)
In-Reply-To: <1497544930-19174-7-git-send-email-axboe@kernel.dk> (Jens Axboe's message of "Thu, 15 Jun 2017 10:42:04 -0600")
Jens,
> +static const unsigned int rwf_write_to_opf_flag[] = {
> + 0, REQ_WRITE_SHORT, REQ_WRITE_MEDIUM, REQ_WRITE_LONG, REQ_WRITE_EXTREME
> +};
Minor nit: When I see WRITE_SHORT I instinctively think data corruption.
Can we make these REQ_LIFETIME_SHORT or something instead? It loses the
WRITE moniker which I'm not so keen on. But I'm not sure how we'd define
read lifetime...
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-06-16 16:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 16:41 [PATCHSET v5] Add support for write life time hints Jens Axboe
2017-06-15 16:41 ` [PATCH 01/12] block: add support for carrying stream information in a bio Jens Axboe
2017-06-16 16:39 ` Martin K. Petersen
2017-06-16 16:42 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 02/12] blk-mq: expose stream write stats through debugfs Jens Axboe
2017-06-16 16:38 ` Martin K. Petersen
2017-06-16 16:41 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 03/12] fs: add support for an inode to carry write hint related data Jens Axboe
2017-06-15 16:42 ` [PATCH 04/12] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-15 16:42 ` [PATCH 05/12] fs: add fcntl() interface for setting/getting " Jens Axboe
2017-06-16 16:44 ` Martin K. Petersen
2017-06-16 16:55 ` Jens Axboe
2017-06-16 17:59 ` Christoph Hellwig
2017-06-15 16:42 ` [PATCH 06/12] block: add helpers for setting/checking write hint validity Jens Axboe
2017-06-16 16:47 ` Martin K. Petersen [this message]
2017-06-16 16:53 ` Jens Axboe
2017-06-15 16:42 ` [PATCH 07/12] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-15 16:42 ` [PATCH 08/12] fs: add support for buffered writeback to pass down write hints Jens Axboe
2017-06-15 16:42 ` [PATCH 09/12] ext4: add support for passing in write hints for buffered writes Jens Axboe
2017-06-15 16:42 ` [PATCH 10/12] xfs: " Jens Axboe
2017-06-15 16:42 ` [PATCH 11/12] btrfs: " Jens Axboe
2017-06-15 16:42 ` [PATCH 12/12] nvme: add support for streams and directives Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1a857q3pt.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.