All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>, Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>,
	Zdenek Kabelac <zkabelac@redhat.com>,
	Milan Broz <gmazyland@gmail.com>,
	linux-block@vger.kernel.org, dm-devel@lists.linux.dev
Subject: Re: [PATCH] blk-settings: round down io_opt to at least 4K
Date: Mon, 03 Feb 2025 22:30:42 -0500	[thread overview]
Message-ID: <yq1bjviflwb.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <28dcf41a-db7d-f8e7-d6b7-acef325c758c@redhat.com> (Mikulas Patocka's message of "Mon, 3 Feb 2025 22:05:27 +0100 (CET)")


Mikulas,

> Do you think that SSDs benefit from more alignment than 4K?

It really depends on the SSD.

> If you have some SSD that has higher IOPS with alignment larger than
> 4K, let me know.

Absolutely.

There are devices out there reporting characteristics that are not
intuitively correct. I.e. not obvious powers of two due to internal
striping or allocation units. Some devices prefer an alignment of 768KB,
for instance. Also, wide RAID stripes can end up causing peculiar
alignment to be reported.

Instead of assuming that 4KB is the correct value for all devices, I'd
rather address the cases where one particular device is reporting
something wrong.

I'm willing to entertain having a quirk to ignore reported values of
0xffff (have also seen 0xfffe) for USB-ATA bridge devices. But I don't
think we should blindly distrust what devices using other transport
classes happen to report, it's usually only USB bridges that are spewing
nonsense. Which is why we typically avoid trying to make sense of VPD
pages on USB in the first place.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2025-02-04  3:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 15:16 [PATCH] blk-settings: round down io_opt to at least 4K Mikulas Patocka
2025-01-22  6:12 ` Christoph Hellwig
2025-02-03 13:38   ` Mikulas Patocka
2025-02-03 19:02     ` Martin K. Petersen
2025-02-03 21:05       ` Mikulas Patocka
2025-02-04  3:30         ` Martin K. Petersen [this message]
2025-02-04  5:57           ` Christoph Hellwig
2025-02-04 13:02             ` Martin K. Petersen
2025-02-04 13:50               ` Christoph Hellwig
2025-02-05  2:36                 ` Martin K. Petersen
2025-02-05 16:00                   ` Christoph Hellwig
2025-02-04 14:56           ` Mikulas Patocka
2025-02-05  2:41             ` Martin K. Petersen
2025-02-10 12:54               ` Mikulas Patocka
2025-02-10 17:02                 ` Milan Broz
2025-02-04  5:56         ` Christoph Hellwig
2025-02-04  5:55     ` Christoph Hellwig
2025-01-23 12:24 ` Milan Broz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1bjviflwb.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=gmazyland@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@kernel.org \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.