From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5297DC2BA2B for ; Tue, 14 Apr 2020 01:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20D522075E for ; Tue, 14 Apr 2020 01:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="f118bmKg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390703AbgDNBQa (ORCPT ); Mon, 13 Apr 2020 21:16:30 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36744 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728066AbgDNBQa (ORCPT ); Mon, 13 Apr 2020 21:16:30 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03E1D77M051584; Tue, 14 Apr 2020 01:16:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=B9l97FxVTVxrtykzgGyVI+iuMIXitMTSx1cS/VeQbv0=; b=f118bmKgYB+0jjWkENBkQymLtRU6xsVR6sxP3MgjoisCGaeZpk/yF6GO/SRQoq3anjTp eZ/LtBz2I5DawHrMVa+ZdoPjsutE+6g7rW1F4NxYJF8WQK+FS+u0SeTFlvo0ss4TGMJZ Pt8zJBPZF1wN0y1NR6Q5El0wXf77rCOKoqW7nXbyQTCE571P5K0gg8msiJ2yU6KKC1mP X2jtCXBIdKFMT1gyxwKbPP5ycgbu21vilWjdlNYZqhofz3NAdSvgan46yPdpUfOqeJ0v 5uCDudQ7xAUSk6zmQwul457xr9nI3h4qD43HM38/0E8IKDA3FeK6Ldh68ZXlAGWXCDSf tw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2130.oracle.com with ESMTP id 30b5ar1m22-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Apr 2020 01:16:22 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03E1Ctnt021682; Tue, 14 Apr 2020 01:16:22 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 30bqm00uu7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Apr 2020 01:16:21 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 03E1GGCL003921; Tue, 14 Apr 2020 01:16:20 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Apr 2020 18:16:16 -0700 To: Daniel Wagner Cc: linux-scsi@vger.kernel.org, Hannes Reinecke , Saurav Kashyap Subject: Re: [PATCH v2] scsi: qedf: Simplify mutex_unlock() usage From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200403092717.19779-1-dwagner@suse.de> Date: Mon, 13 Apr 2020 21:16:14 -0400 In-Reply-To: <20200403092717.19779-1-dwagner@suse.de> (Daniel Wagner's message of "Fri, 3 Apr 2020 11:27:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=916 adultscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004140007 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9590 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=991 suspectscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004140007 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Daniel, > The commit 6d1368e8f987 ("scsi: qedf: fixup locking in > qedf_restart_rport()") introduced the lock. Though the lock protects > only the fc_rport_create() call. Thus, we can move the mutex unlock up > before the if statement and drop the else body. Applied to 5.8/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering