From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: "Elliott\, Robert \(Servers\)" <elliott@hpe.com>,
"martin.petersen\@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi\@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"sathya.prakash\@broadcom.com" <sathya.prakash@broadcom.com>,
"suganath-prabu.subramani\@broadcom.com"
<suganath-prabu.subramani@broadcom.com>,
"stable\@vger.kernel.org" <stable@vger.kernel.org>,
"amit\@kernel.org" <amit@kernel.org>
Subject: Re: [PATCH] mpt3sas: Fix kernel panic observed on soft HBA unplug
Date: Thu, 26 Mar 2020 21:50:47 -0400 [thread overview]
Message-ID: <yq1bloiftvs.fsf@oracle.com> (raw)
In-Reply-To: <CAK=zhgqWJs+Wbmgy9xp6WDRp2w5e+5BGD+R5mck-dVh5oOUQ0g@mail.gmail.com> (Sreekanth Reddy's message of "Mon, 16 Mar 2020 11:45:15 +0530")
Sreekanth,
> In the unload path driver call sas_remove_host() API before releasing
> the resources. This sas_remove_host() API waits for all the
> outstanding IOs to be completed. So here, indirectly driver is waiting
> for the outstanding IOs to be processed before releasing the HBA
> resources. So only in the cases where HBA is inaccessible (e.g. HBA
> unplug case), driver is flushing out the outstanding commands to avoid
> SCSI error handling over head and can quilkey complete the driver
> unload operation.
None of this is clear from the commit description. Please resubmit patch
with a new description clarifying why and when it is safe to drop
outstanding commands.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-03-27 1:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 10:36 [PATCH] mpt3sas: Fix kernel panic observed on soft HBA unplug Sreekanth Reddy
2020-03-11 11:04 ` Amit Shah
2020-03-11 11:25 ` Sreekanth Reddy
2020-03-11 11:49 ` Sreekanth Reddy
2020-03-11 14:48 ` Amit Shah
2020-03-14 2:25 ` Elliott, Robert (Servers)
2020-03-14 2:25 ` Elliott, Robert (Servers)
2020-03-16 6:15 ` Sreekanth Reddy
2020-03-27 1:50 ` Martin K. Petersen [this message]
2020-03-27 10:35 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bloiftvs.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=amit@kernel.org \
--cc=elliott@hpe.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.