From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
Date: Tue, 17 Dec 2019 17:28:28 -0500 [thread overview]
Message-ID: <yq1bls6h9ir.fsf@oracle.com> (raw)
In-Reply-To: <20191217180840.9414-1-msuchanek@suse.de> (Michal Suchanek's message of "Tue, 17 Dec 2019 19:08:40 +0100")
Michal,
> + {"VMware", "VMware", NULL, BLIST_NO_MATCH_VENDOR | BLIST_NO_TRAY},
Please don't introduce a blist flag to work around deficiencies in the
matching interface. I suggest you tweak the matching functions so they
handle a NULL vendor string correctly.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-12-17 22:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 18:08 [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation Michal Suchanek
2019-12-17 22:28 ` Martin K. Petersen [this message]
2019-12-19 14:34 ` Michal Suchánek
2019-12-19 23:31 ` Martin K. Petersen
2019-12-20 14:39 ` Michal Suchánek
2019-12-21 11:54 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bls6h9ir.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.