From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Hannes Reinecke <hare@suse.de>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fcoe: remove redundant call to skb_transport_header
Date: Thu, 29 Aug 2019 21:45:05 +0000 [thread overview]
Message-ID: <yq1blw7sl26.fsf@oracle.com> (raw)
In-Reply-To: <20190815091454.13430-1-colin.king@canonical.com> (Colin King's message of "Thu, 15 Aug 2019 10:14:54 +0100")
Colin,
> Pointer fh is being assigned a return value from the call to
> skb_transport_header however this value is never read and fh is being
> re-assigned immediately afterwards with a new value. Since there are
> side-effects from calling skb_transport_header the call is redundant
> and can be removed.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Hannes Reinecke <hare@suse.de>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fcoe: remove redundant call to skb_transport_header
Date: Thu, 29 Aug 2019 17:45:05 -0400 [thread overview]
Message-ID: <yq1blw7sl26.fsf@oracle.com> (raw)
In-Reply-To: <20190815091454.13430-1-colin.king@canonical.com> (Colin King's message of "Thu, 15 Aug 2019 10:14:54 +0100")
Colin,
> Pointer fh is being assigned a return value from the call to
> skb_transport_header however this value is never read and fh is being
> re-assigned immediately afterwards with a new value. Since there are
> side-effects from calling skb_transport_header the call is redundant
> and can be removed.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-08-29 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 9:14 [PATCH] scsi: fcoe: remove redundant call to skb_transport_header Colin King
2019-08-15 9:14 ` Colin King
2019-08-29 21:45 ` Martin K. Petersen [this message]
2019-08-29 21:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1blw7sl26.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.king@canonical.com \
--cc=hare@suse.de \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.