From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Thu, 29 Aug 2019 21:45:05 +0000 Subject: Re: [PATCH] scsi: fcoe: remove redundant call to skb_transport_header Message-Id: List-Id: References: <20190815091454.13430-1-colin.king@canonical.com> In-Reply-To: <20190815091454.13430-1-colin.king@canonical.com> (Colin King's message of "Thu, 15 Aug 2019 10:14:54 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > Pointer fh is being assigned a return value from the call to > skb_transport_header however this value is never read and fh is being > re-assigned immediately afterwards with a new value. Since there are > side-effects from calling skb_transport_header the call is redundant > and can be removed. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF068C3A59F for ; Thu, 29 Aug 2019 21:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E911206BB for ; Thu, 29 Aug 2019 21:45:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="a14yz4mK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727564AbfH2VpR (ORCPT ); Thu, 29 Aug 2019 17:45:17 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54792 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbfH2VpQ (ORCPT ); Thu, 29 Aug 2019 17:45:16 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7TLY1wI175398; Thu, 29 Aug 2019 21:45:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=eIO6xJhd3OvVUtNUka4JSshLZtUsZwhCJv3TRE9g0EM=; b=a14yz4mKxeyWY+PI52KCDkmqiy0CJ83cm6Qs2qqq8Ldmj6CDia1tbqapzPSKN/uXShjN jkWvz+npIveT6//kaPZliz8fxiIqR4vuAnEBoWDY5/JVi9atC25GF2DsxExs5iTNuC6t GVkytRJ2PpfETeP0NG3oQMQJO1CkNgm6xXs4LR4fnaQ+XAzBgjbeI6AoBDa5xKCUnt14 FjIlWFkmKkG0bY8MOCoOikUZNJaFwBn+YwbvpYxppIyh2up0xGHhBuSmvuCZCqrgPQ3+ dkzWpz21Wg5b//CvZbN+y12zN6OWcIXEvnc2ijNfdJQmB2hLFX+VYDjs22bejImeDHLU nw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2uppjc048p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Aug 2019 21:45:10 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7TLYGgQ129877; Thu, 29 Aug 2019 21:45:10 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 2uphaube58-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Aug 2019 21:45:09 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7TLj8ZY022005; Thu, 29 Aug 2019 21:45:08 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 29 Aug 2019 14:45:08 -0700 To: Colin King Cc: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: fcoe: remove redundant call to skb_transport_header From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190815091454.13430-1-colin.king@canonical.com> Date: Thu, 29 Aug 2019 17:45:05 -0400 In-Reply-To: <20190815091454.13430-1-colin.king@canonical.com> (Colin King's message of "Thu, 15 Aug 2019 10:14:54 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9364 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=975 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908290216 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9364 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908290216 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Colin, > Pointer fh is being assigned a return value from the call to > skb_transport_header however this value is never read and fh is being > re-assigned immediately afterwards with a new value. Since there are > side-effects from calling skb_transport_header the call is redundant > and can be removed. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering