From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dave Carroll <david.carroll@microsemi.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Noah Misner <nmisner@us.ibm.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
Hannes Reinecke <hare@suse.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
aacraid@microsemi.com, Scott Benesh <scott.benesh@microsemi.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] aacraid: Correct hba_send to include iu_type
Date: Tue, 01 May 2018 23:21:40 -0400 [thread overview]
Message-ID: <yq1bmdy7nej.fsf@oracle.com> (raw)
In-Reply-To: <20180425162420.612-1-david.carroll@microsemi.com> (Dave Carroll's message of "Wed, 25 Apr 2018 10:24:20 -0600")
Dave,
> commit b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()")
>
> allows aac_hba_send() to send scsi commands, and TMF requests, but the existing
> code only updates the iu_type for scsi commands. For TMF requests we are sending
> an unknown iu_type to firmware, which causes a fault.
>
> Include iu_type prior to determining the validity of the command
Applied to 4.17/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dave Carroll <david.carroll@microsemi.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Noah Misner <nmisner@us.ibm.com>,
James Bottomley <jejb@linux.vnet.ibm.com>,
"Hannes Reinecke" <hare@suse.com>,
linux-scsi <linux-scsi@vger.kernel.org>, <aacraid@microsemi.com>,
Scott Benesh <scott.benesh@microsemi.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH] aacraid: Correct hba_send to include iu_type
Date: Tue, 01 May 2018 23:21:40 -0400 [thread overview]
Message-ID: <yq1bmdy7nej.fsf@oracle.com> (raw)
In-Reply-To: <20180425162420.612-1-david.carroll@microsemi.com> (Dave Carroll's message of "Wed, 25 Apr 2018 10:24:20 -0600")
Dave,
> commit b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()")
>
> allows aac_hba_send() to send scsi commands, and TMF requests, but the existing
> code only updates the iu_type for scsi commands. For TMF requests we are sending
> an unknown iu_type to firmware, which causes a fault.
>
> Include iu_type prior to determining the validity of the command
Applied to 4.17/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-05-02 3:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 16:24 [PATCH] aacraid: Correct hba_send to include iu_type Dave Carroll
2018-04-25 16:24 ` Dave Carroll
2018-04-25 20:37 ` Brian King
2018-05-02 3:21 ` Martin K. Petersen [this message]
2018-05-02 3:21 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1bmdy7nej.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=david.carroll@microsemi.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nmisner@us.ibm.com \
--cc=scott.benesh@microsemi.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.