From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Date: Tue, 27 Jun 2017 21:32:02 -0400 Message-ID: References: <20170623071011.21184-1-jthumshirn@suse.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:50100 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261AbdF1BcT (ORCPT ); Tue, 27 Jun 2017 21:32:19 -0400 In-Reply-To: <20170623071011.21184-1-jthumshirn@suse.de> (Johannes Thumshirn's message of "Fri, 23 Jun 2017 09:10:11 +0200") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux SCSI Mailinglist , Linux Kernel Mailinglist , qla2xxx-upstream@qlogic.com, Himanshu Madhani , Hannes Reinecke , John Garry > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members under the qpair->qp_lock. Cavium folks, please review! -- Martin K. Petersen Oracle Linux Engineering