From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Steffen Maier <maier@linux.ibm.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Benjamin Block <bblock@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] zfcp: fix reaction on bit error theshold notification with adapter close
Date: Mon, 30 Sep 2019 23:49:26 -0400 [thread overview]
Message-ID: <yq1d0fhw2ex.fsf@oracle.com> (raw)
In-Reply-To: <20190924160616.15301-1-maier@linux.ibm.com> (Steffen Maier's message of "Tue, 24 Sep 2019 18:06:16 +0200")
Steffen,
> Kernel message explanation:
>
> * Description:
> * The FCP channel reported that its bit error threshold has been exceeded.
> * These errors might result from a problem with the physical components
> * of the local fibre link into the FCP channel.
> * The problem might be damage or malfunction of the cable or
> * cable connection between the FCP channel and
> * the adjacent fabric switch port or the point-to-point peer.
> * Find details about the errors in the HBA trace for the FCP device.
> * The zfcp device driver closed down the FCP device
> * to limit the performance impact from possible I/O command timeouts.
> * User action:
> * Check for problems on the local fibre link, ensure that fibre optics are
> * clean and functional, and all cables are properly plugged.
> * After the repair action, you can manually recover the FCP device by
> * writing "0" into its "failed" sysfs attribute.
> * If recovery through sysfs is not possible, set the CHPID of the device
> * offline and back online on the service element.
This commentary does not read like a patch description. It makes no
mention of the actual kernel changes and the introduced module
parameter.
> +static bool ber_stop = true;
> +module_param(ber_stop, bool, 0600);
> +MODULE_PARM_DESC(ber_stop,
> + "Shuts down FCP devices for FCP channels that report a bit-error count in excess of its threshold (default on)");
> +
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-10-01 3:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 16:06 [PATCH] zfcp: fix reaction on bit error theshold notification with adapter close Steffen Maier
[not found] ` <20190925224305.00183208C3@mail.kernel.org>
2019-09-26 11:00 ` Steffen Maier
2019-10-01 3:49 ` Martin K. Petersen [this message]
2019-10-01 10:49 ` [PATCH v2] " Steffen Maier
2019-10-01 14:14 ` Greg KH
2019-10-01 15:07 ` Steffen Maier
2019-10-01 15:42 ` Greg KH
2019-10-01 18:26 ` Martin K. Petersen
2019-10-02 8:31 ` Steffen Maier
2019-10-04 1:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0fhw2ex.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bblock@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.