From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>
Subject: Re: [PATCH] scsi: ufs: Fix NULL pointer dereference in ufshcd_config_vreg_hpm()
Date: Wed, 14 Aug 2019 22:08:00 -0400 [thread overview]
Message-ID: <yq1d0h72nb3.fsf@oracle.com> (raw)
In-Reply-To: <20190814125950.22850-1-adrian.hunter@intel.com> (Adrian Hunter's message of "Wed, 14 Aug 2019 15:59:50 +0300")
Adrian,
> Fix the following BUG:
>
> [ 187.065689] BUG: kernel NULL pointer dereference, address: 000000000000001c
> [ 187.065790] RIP: 0010:ufshcd_vreg_set_hpm+0x3c/0x110 [ufshcd_core]
> [ 187.065938] Call Trace:
> [ 187.065959] ufshcd_resume+0x72/0x290 [ufshcd_core]
> [ 187.065980] ufshcd_system_resume+0x54/0x140 [ufshcd_core]
> [ 187.065993] ? pci_pm_restore+0xb0/0xb0
> [ 187.066005] ufshcd_pci_resume+0x15/0x20 [ufshcd_pci]
> [ 187.066017] pci_pm_thaw+0x4c/0x90
> [ 187.066030] dpm_run_callback+0x5b/0x150
> [ 187.066043] device_resume+0x11b/0x220
>
> Voltage regulators are optional, so functions must check they exist
> before dereferencing.
>
> Note this issue is hidden if CONFIG_REGULATORS is not set, because the
> offending code is optimised away.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2019-08-15 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 12:59 [PATCH] scsi: ufs: Fix NULL pointer dereference in ufshcd_config_vreg_hpm() Adrian Hunter
2019-08-15 2:08 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0h72nb3.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pedrom.sousa@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.