From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk
Date: Tue, 11 Jun 2019 23:40:29 -0400 [thread overview]
Message-ID: <yq1d0jjeaj6.fsf@oracle.com> (raw)
In-Reply-To: <20190611143259.28647-1-hdegoede@redhat.com> (Hans de Goede's message of "Tue, 11 Jun 2019 16:32:59 +0200")
Hans,
> - /* drives which fail FPDMA_AA activation (some may freeze afterwards) */
> - { "ST1000LM024 HN-M101MBB", "2AR10001", ATA_HORKAGE_BROKEN_FPDMA_AA },
> - { "ST1000LM024 HN-M101MBB", "2BA30001", ATA_HORKAGE_BROKEN_FPDMA_AA },
> + /* drives which fail FPDMA_AA activation (some may freeze afterwards)
> + the ST disks also have LPM issues */
> + { "ST1000LM024 HN-M101MBB", "2AR10001", ATA_HORKAGE_BROKEN_FPDMA_AA |
> + ATA_HORKAGE_NOLPM, },
> + { "ST1000LM024 HN-M101MBB", "2BA30001", ATA_HORKAGE_BROKEN_FPDMA_AA |
> + ATA_HORKAGE_NOLPM, },
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Slightly orthogonal, and I know it's been discussed before, but I think
it would be worth considering just blacklisting all firmware revs for
this model.
There were several firmware releases for these drives. And while it's
conceivable that post-2BA30001 may fix the issues, I think it's safe to
say that all the intermediate releases between the two we have are
equally broken.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-06-12 3:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:32 [PATCH] libata: Extend quirks for the ST1000LM024 drives with NOLPM quirk Hans de Goede
2019-06-12 3:40 ` Martin K. Petersen [this message]
2019-06-12 5:33 ` Hans de Goede
2019-06-13 2:10 ` Martin K. Petersen
2019-06-13 9:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0jjeaj6.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=axboe@kernel.dk \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.