From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: remove declaration of nvm_image from stack
Date: Fri, 29 Mar 2019 14:04:53 +0000 [thread overview]
Message-ID: <yq1d0m9srne.fsf@oracle.com> (raw)
In-Reply-To: <20190327181103.15677-1-colin.king@canonical.com> (Colin King's message of "Wed, 27 Mar 2019 18:11:03 +0000")
Colin,
> The nvm_image is a large struct qedi_nvm_iscsi_image object of over
> 24K so don't declare it on the stack just for a sizeof requirement;
> use sizeof on struct qedi_nvm_iscsi_image instead.
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: QLogic-Storage-Upstream@cavium.com,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: remove declaration of nvm_image from stack
Date: Fri, 29 Mar 2019 10:04:53 -0400 [thread overview]
Message-ID: <yq1d0m9srne.fsf@oracle.com> (raw)
In-Reply-To: <20190327181103.15677-1-colin.king@canonical.com> (Colin King's message of "Wed, 27 Mar 2019 18:11:03 +0000")
Colin,
> The nvm_image is a large struct qedi_nvm_iscsi_image object of over
> 24K so don't declare it on the stack just for a sizeof requirement;
> use sizeof on struct qedi_nvm_iscsi_image instead.
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-03-29 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 18:11 [PATCH] scsi: qedi: remove declaration of nvm_image from stack Colin King
2019-03-28 5:53 ` Manish Rangankar
2019-03-28 5:53 ` Manish Rangankar
2019-03-29 14:04 ` Martin K. Petersen [this message]
2019-03-29 14:04 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d0m9srne.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=QLogic-Storage-Upstream@cavium.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.