From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 0/3] SCSI device blacklist handling improvements
Date: Thu, 07 Dec 2017 20:10:22 -0500 [thread overview]
Message-ID: <yq1d13qvxc1.fsf@oracle.com> (raw)
In-Reply-To: <1512668081.2624.24.camel@wdc.com> (Bart Van Assche's message of "Thu, 7 Dec 2017 17:34:43 +0000")
Bart,
> Are you perhaps referring to the five __force casts? If so, do you
> have a suggestion for avoiding that sparse reports false positive
> warnings on the conversions between int and blist_flags_t? The only
> approach I can think of to reduce the number of __force casts is to
> embed these __force casts into two helper functions - one for the
> conversion from int to blist_flags_t and one for the conversion the
> other way around.
blist_flags_t is an unsigned int, you are forcing it to u32 two
places. That's a problem waiting to happen next time we add a blacklist
flag.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-12-08 1:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 18:36 [PATCH 0/3] SCSI device blacklist handling improvements Bart Van Assche
2017-12-04 18:36 ` [PATCH 1/3] scsi_get_device_flags_keyed(): Always return device flags Bart Van Assche
2017-12-04 18:36 ` [PATCH 2/3] Use blist_flags_t consistently Bart Van Assche
2017-12-04 18:36 ` [PATCH 3/3] Introduce scsi_devinfo_key enumeration type Bart Van Assche
2017-12-07 2:03 ` [PATCH 0/3] SCSI device blacklist handling improvements Martin K. Petersen
2017-12-07 17:34 ` Bart Van Assche
2017-12-08 1:10 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d13qvxc1.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@wdc.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.