From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: weiping zhang <zhangweiping@didichuxing.com>
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: add check for changing allow_restart
Date: Wed, 11 Oct 2017 13:22:18 -0400 [thread overview]
Message-ID: <yq1d15tha5x.fsf@oracle.com> (raw)
In-Reply-To: <20170927165313.GA36250@localhost.didichuxing.com> (weiping zhang's message of "Thu, 28 Sep 2017 00:53:18 +0800")
weiping,
> /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> writing invalid string, like following:
>
> echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart
Please switch to kstrtobool() and fix up manage_start_stop as well.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-10-11 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 16:53 [PATCH] scsi: sd: add check for changing allow_restart weiping zhang
2017-10-07 8:47 ` weiping zhang
2017-10-11 17:22 ` Martin K. Petersen [this message]
2017-10-12 6:22 ` weiping zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d15tha5x.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.