From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test
Date: Wed, 23 Aug 2017 22:45:46 -0400 [thread overview]
Message-ID: <yq1d17ladk5.fsf@oracle.com> (raw)
In-Reply-To: <20170822205353.GA17794@embeddedgus> (Gustavo A. R. Silva's message of "Tue, 22 Aug 2017 15:53:53 -0500")
Gustavo,
> Remove variable assignments. The value stored in local variable _rc_
> is overwritten at line 2448:rc =
> lpfc_sli4_bsg_set_link_diag_state(phba, 0); before it can be used.
Applied to 4.14/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-08-24 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 20:53 [PATCH] scsi: lpfc: remove useless code in lpfc_sli4_bsg_link_diag_test Gustavo A. R. Silva
2017-08-23 16:20 ` James Smart
2017-08-24 2:45 ` Martin K. Petersen [this message]
2017-08-24 15:26 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d17ladk5.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=gustavo@embeddedor.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.