From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
"Christoph Hellwig" <hch@lst.de>,
"James Bottomley" <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
"Bodo Stroesser" <bstroesser@ts.fujitsu.com>,
"Hannes Reinecke" <hare@suse.com>
Subject: Re: [PATCH] st: fix blk_get_queue usage
Date: Mon, 07 Aug 2017 13:40:20 -0400 [thread overview]
Message-ID: <yq1d1879szf.fsf@oracle.com> (raw)
In-Reply-To: <1501591374-11229-1-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Tue, 1 Aug 2017 14:42:54 +0200")
Hannes,
> If blk_queue_get() in st_probe fails, disk->queue must not be set to
> SDp->request_queue, as that would result in put_disk() dropping a not
> taken reference.
>
> Thus, disk->queue should be set only after a successful
> blk_queue_get().
Applied to 4.13/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-08-07 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 12:42 [PATCH] st: fix blk_get_queue usage Hannes Reinecke
2017-08-01 16:03 ` Ewan D. Milne
2017-08-01 19:19 ` "Kai Mäkisara (Kolumbus)"
2017-08-07 17:40 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d1879szf.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=bstroesser@ts.fujitsu.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.