From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 7/9] Guard bvec iteration logic
Date: Wed, 10 May 2017 18:45:22 -0400 [thread overview]
Message-ID: <yq1d1bgmiv1.fsf@oracle.com> (raw)
In-Reply-To: <1494429652-9488-8-git-send-email-dmonakhov@openvz.org> (Dmitry Monakhov's message of "Wed, 10 May 2017 19:20:50 +0400")
Dmitry,
> Currently if some one try to advance bvec beyond it's size we simply
> dump WARN_ONCE and continue to iterate beyond bvec array boundaries.
> This simply means that we endup dereferencing/corrupting random memory
> region.
>
> Sane reaction would be to propagate error back to calling context But
> bvec_iter_advance's calling context is not always good for error
> handling. For safity reason let truncate iterator size to zero which
> will break external iteration loop which prevent us from unpredictable
> memory range corruption. And even it caller ignores an error, it will
> corrupt it's own bvecs, not others.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-05-10 22:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 15:20 [PATCH 0/9] block: T10/DIF Fixes and cleanups v4 Dmitry Monakhov
2017-05-10 15:20 ` [PATCH 1/9] bio-integrity: Do not allocate integrity context for bio w/o data Dmitry Monakhov
2017-05-11 7:30 ` Christoph Hellwig
2017-05-21 7:12 ` Christoph Hellwig
2017-05-10 15:20 ` [PATCH 2/9] bio-integrity: bio_trim should truncate integrity vector accordingly Dmitry Monakhov
2017-05-10 15:20 ` [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed Dmitry Monakhov
2017-05-10 22:40 ` Martin K. Petersen
2017-05-10 15:20 ` [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim Dmitry Monakhov
2017-05-10 15:20 ` [PATCH 5/9] bio-integrity: fold bio_integrity_enabled to bio_integrity_prep Dmitry Monakhov
2017-05-10 22:42 ` Martin K. Petersen
2017-05-11 7:31 ` Christoph Hellwig
2017-05-10 15:20 ` [PATCH 6/9] T10: Move opencoded contants to common header Dmitry Monakhov
2017-05-10 22:43 ` Martin K. Petersen
2017-05-11 7:32 ` Christoph Hellwig
2017-05-10 15:20 ` [PATCH 7/9] Guard bvec iteration logic Dmitry Monakhov
2017-05-10 22:45 ` Martin K. Petersen [this message]
2017-05-11 7:32 ` Christoph Hellwig
2017-05-11 7:46 ` Ming Lei
2017-05-10 15:20 ` [PATCH 8/9] bio: add bvec_iter rewind API Dmitry Monakhov
2017-05-10 15:20 ` [PATCH 9/9] bio-integrity: Restore original iterator on verify stage Dmitry Monakhov
2017-06-16 6:44 ` [PATCH 0/9] block: T10/DIF Fixes and cleanups v4 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d1bgmiv1.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dmonakhov@openvz.org \
--cc=fstests@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.