From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Steffen Maier <maier@linux.vnet.ibm.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"#2 . 6 . 38+" <stable@vger.kernel.org>
Subject: Re: [PATCH] zfcp: fix use-after-free by not tracing WKA port open/close on failed send
Date: Thu, 09 Feb 2017 19:02:48 -0500 [thread overview]
Message-ID: <yq1d1eqkj4n.fsf@oracle.com> (raw)
In-Reply-To: <20170208143422.64943-1-maier@linux.vnet.ibm.com> (Steffen Maier's message of "Wed, 8 Feb 2017 15:34:22 +0100")
>>>>> "Steffen" == Steffen Maier <maier@linux.vnet.ibm.com> writes:
Steffen> Rather than relying on req being NULL (or ERR_PTR) for all
Steffen> cases where we don't want to trace or should not trace, simply
Steffen> check retval which is unconditionally initialized with -EIO !=
Steffen> 0 and it can only become 0 on successful retval =
Steffen> zfcp_fsf_req_send(req). With that we can also remove the then
Steffen> again unnecessary unconditional initialization of req which was
Steffen> introduced with that earlier commit.
Applied to 4.10/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-02-10 0:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 14:34 [PATCH] zfcp: fix use-after-free by not tracing WKA port open/close on failed send Steffen Maier
2017-02-10 0:02 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d1eqkj4n.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.