From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Tom Yan <tom.ty89@gmail.com>, Tejun Heo <tj@kernel.org>,
jmoyer@redhat.com, axboe@fb.com, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices
Date: Fri, 12 Aug 2016 17:17:22 -0400 [thread overview]
Message-ID: <yq1d1ldn0v1.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20160812101645.0a4a5e9f@lxorguk.ukuu.org.uk> (One Thousand Gnomes's message of "Fri, 12 Aug 2016 10:16:45 +0100")
>>>>> "Alan" == One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> writes:
Alan,
Alan> For older SCSI and especially ATA drives (and it wouldn't surprise
Alan> me if it is true of modern ones) there are also huge latency
Alan> tradeoffs.
Absolutely.
Alan> Before you jump up and down about numbers what are the latency
Alan> numbers like on classic ATA drives with that sized block I/O. You
Alan> could easily up your RAID numbers while wrecking realtime and
Alan> desktop performance.
I was in no way advocating raising the default, quite the contrary. We
have several customer workloads that got negatively impacted when the
limit was bumped.
My point was that arguing about what the default should be without any
data supporting the discussion is futile.
Alan> At the ATA level we can detect both the presence of command
Alan> queueing ability, and also whether the device is spinnning rust or
Alan> not, so it may be smarter defaults could be done based upon
Alan> whether the device is an SSD or not.
Sure.
However, modern SSDs actually trend towards smaller I/O sizes. NVMe is
128K by default, I think. So a higher default wouldn't make any
difference there.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-08-12 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 14:45 [PATCH v2 1/2] libata-scsi: set max_hw_sectors again only when dev->max_sectors is set tom.ty89
2016-08-09 14:45 ` [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices tom.ty89
2016-08-09 16:50 ` Sergei Shtylyov
2016-08-10 4:10 ` Tejun Heo
2016-08-10 8:32 ` Tom Yan
2016-08-10 15:22 ` Tejun Heo
2016-08-11 3:37 ` Martin K. Petersen
2016-08-11 9:30 ` Tom Yan
2016-08-12 2:01 ` Martin K. Petersen
2016-08-12 5:18 ` Tom Yan
2016-08-12 8:17 ` Tom Yan
2016-08-12 21:06 ` Martin K. Petersen
2016-08-12 9:16 ` One Thousand Gnomes
2016-08-12 21:17 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1d1ldn0v1.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=axboe@fb.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jmoyer@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.