All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James.Bottomley@hansenpartnership.com
Cc: Stuart Foster <smf.linux@ntlworld.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Ed Tomlinson <edt@aei.ca>, USB list <linux-usb@vger.kernel.org>,
	SCSI development list <linux-scsi@vger.kernel.org>,
	stable@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"
Date: Tue, 30 Jul 2013 22:58:34 -0400	[thread overview]
Message-ID: <yq1d2pzigf9.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1307301441510.893-100000@iolanthe.rowland.org> (Alan Stern's message of "Tue, 30 Jul 2013 14:44:23 -0400 (EDT)")

>>>>> "Alan" == Alan Stern <stern@rowland.harvard.edu> writes:

Alan> On Mon, 29 Jul 2013, Stuart Foster wrote:
>> Hi Alan,
>> 
>> The patch is good for me.
>> 
>> thanks

Alan> There also have been positive reports from Marc Meledandri and
Alan> Philipp Dreimann.

Alan> Martin, please submit your patch for inclusion in the stable
Alan> kernels as soon as possible.

James?

[PATCH] SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set

If a device has the skip_vpd_pages flag set we should simply fail the
scsi_get_vpd_page() call.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Stuart Foster <smf.linux@ntlworld.com>
Cc: stable@vger.kernel.org

diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 3b1ea34..eaa808e 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -1031,6 +1031,9 @@ int scsi_get_vpd_page(struct scsi_device *sdev, u8 page, unsigned char *buf,
 {
 	int i, result;
 
+	if (sdev->skip_vpd_pages)
+		goto fail;
+
 	/* Ask for all the pages supported by this device */
 	result = scsi_vpd_inquiry(sdev, buf, 0, buf_len);
 	if (result)

  reply	other threads:[~2013-07-31  2:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51F44125.2040803@ntlworld.com>
2013-07-28 19:28 ` Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd" Alan Stern
     [not found]   ` <Pine.LNX.4.44L0.1307281505410.18237-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-07-29  7:21     ` Stuart Foster
2013-07-29 15:06   ` Martin K. Petersen
2013-07-29 15:23     ` Alan Stern
2013-07-29 15:28       ` Martin K. Petersen
2013-07-29 16:33       ` Stuart Foster
2013-07-30 18:44         ` Alan Stern
2013-07-31  2:58           ` Martin K. Petersen [this message]
2013-07-31 14:50             ` Alan Stern
2013-08-02 10:32   ` Peter Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1d2pzigf9.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=edt@aei.ca \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=smf.linux@ntlworld.com \
    --cc=stable@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.