From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Anuj Gupta <anuj20.g@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
linux-block@vger.kernel.org
Subject: Re: more integrity cleanups v3
Date: Tue, 02 Jul 2024 22:18:05 -0400 [thread overview]
Message-ID: <yq1ed8bcj81.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240702151047.1746127-1-hch@lst.de> (Christoph Hellwig's message of "Tue, 2 Jul 2024 17:10:18 +0200")
Christoph,
> this series has more cleanups to the block layer integrity code. It
> splits the bio integrity APIs into their own header as they are only
> used by very few source files, cleans up their stubs a little bit, and
> then in the last patch change when the bio_integrity_payload is freed
> when it is not owned by the block layer. This avoids having to know
> the submitter in the core code and will simplify adding other consuer
> of the API like file systems or the io_uring non-passthrough PI
> support.
Looks good to me and is more in line with how this originally worked.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-03 2:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 15:10 more integrity cleanups v3 Christoph Hellwig
2024-07-02 15:10 ` [PATCH 1/6] block: split integrity support out of bio.h Christoph Hellwig
2024-07-03 9:28 ` Johannes Thumshirn
2024-07-02 15:10 ` [PATCH 2/6] block: also return bio_integrity_payload * from stubs Christoph Hellwig
2024-07-03 9:29 ` Johannes Thumshirn
2024-07-02 15:10 ` [PATCH 3/6] block: don't call bio_uninit from bio_endio Christoph Hellwig
2024-07-03 9:50 ` Johannes Thumshirn
2024-07-04 7:23 ` hch
2024-07-02 15:10 ` [PATCH 4/6] block: call bio_integrity_unmap_free_user from blk_rq_unmap_user Christoph Hellwig
2024-07-03 9:32 ` Johannes Thumshirn
2024-07-02 15:10 ` [PATCH 5/6] block: don't free submitter owned integrity payload on I/O completion Christoph Hellwig
2024-07-03 9:33 ` Johannes Thumshirn
2024-07-03 12:19 ` Kanchan Joshi
2024-07-02 15:10 ` [PATCH 6/6] block: don't free the integrity payload in bio_integrity_unmap_free_user Christoph Hellwig
2024-07-03 9:33 ` Johannes Thumshirn
2024-07-03 12:21 ` Kanchan Joshi
2024-07-03 2:18 ` Martin K. Petersen [this message]
2024-07-03 16:21 ` more integrity cleanups v3 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ed8bcj81.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.