From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Tue, 01 Oct 2019 02:43:02 +0000 Subject: Re: [PATCH] scsi: mvsas: remove redundant assignment to variable rc Message-Id: List-Id: References: <20190905135017.23772-1-colin.king@canonical.com> In-Reply-To: <20190905135017.23772-1-colin.king@canonical.com> (Colin King's message of "Thu, 5 Sep 2019 14:50:17 +0100") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin, > The variable rc is being initialized with a value that is never read > and is being re-assigned a little later on. The assignment is > redundant and hence can be removed. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05525C32792 for ; Tue, 1 Oct 2019 02:43:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB4392087F for ; Tue, 1 Oct 2019 02:43:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="iRg/y3i0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731549AbfJACnt (ORCPT ); Mon, 30 Sep 2019 22:43:49 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:58062 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728133AbfJACnt (ORCPT ); Mon, 30 Sep 2019 22:43:49 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912eNOg070025; Tue, 1 Oct 2019 02:43:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=ysbJMTAWRnoqFPAjb9+nsfnvblBeuAaW1c+VwQajuCI=; b=iRg/y3i0FYmhjLplICmXr/3/AfGbBjsPZXWBXhjb1K0theVGF8HpcpLTRMgPUT5G6S8a UV5Gyq4hcLyTDwN41+/9v+r9/6wzN1zQE3QVfXav9VuXU3VrUKEVjv+vUqXLAQorjHSU Z2r5ZJJykpGrbNnTkKYvi0rRw7tjxm4qfmgK+PovnUJjkLiLIn34eBuzJOL0n1L/xIRf 4V6DOGqUTx9KcP0llRs5EVBhMiKAiStbh6Seifpdl02VoKNbTwOzgLa645Wv5hPutGoI m9EGCL3slbYsu6oBh6yvZNSLltZt3VljW1FvQohHhfG0xg4aDyPZnjdr0avHAWSo8gr1 4g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 2v9yfq2u55-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:43:45 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912hgrt018085; Tue, 1 Oct 2019 02:43:44 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2vbmpxgjpc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:43:44 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x912h6li024635; Tue, 1 Oct 2019 02:43:06 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Sep 2019 19:43:06 -0700 To: Colin King Cc: "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: mvsas: remove redundant assignment to variable rc From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190905135017.23772-1-colin.king@canonical.com> Date: Mon, 30 Sep 2019 22:43:02 -0400 In-Reply-To: <20190905135017.23772-1-colin.king@canonical.com> (Colin King's message of "Thu, 5 Sep 2019 14:50:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010027 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010026 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Colin, > The variable rc is being initialized with a value that is never read > and is being re-assigned a little later on. The assignment is > redundant and hence can be removed. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering