From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: qedi: tidy up a size caculation
Date: Mon, 02 Jul 2018 20:17:45 +0000 [thread overview]
Message-ID: <yq1efglz91y.fsf@oracle.com> (raw)
In-Reply-To: <20180628092310.ta2qzatghjtgnzx7@kili.mountain>
Dan,
> The id_tbl->table pointer points to unsigned long so static checkers
> complain that instead of 4 we should be allocating sizeof(long) bytes.
>
> We're trying to allocate enough bits for the bitmap. The size variable
> is always 1024. (1024 / 32 * 4) is the same as (1024 / 64 * 8) so this
> doesn't change runtime, but this is the more idiomatic way to do it and
> makes the static checker happy.
Applied to 4.19/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-07-02 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 9:23 [PATCH] scsi: qedi: tidy up a size caculation Dan Carpenter
2018-06-28 15:15 ` Rangankar, Manish
2018-07-02 20:17 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1efglz91y.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.