From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH v2] lpfc: Fix panic on BFS configuration.
Date: Thu, 27 Apr 2017 12:22:47 -0400 [thread overview]
Message-ID: <yq1efwd95wo.fsf@oracle.com> (raw)
In-Reply-To: <20170426191926.6061-1-jsmart2021@gmail.com> (jsmart's message of "Wed, 26 Apr 2017 12:19:26 -0700")
James,
Please run checkpatch on your submissions.
> This issue was introduced by this patch:
> http://www.spinics.net/lists/linux-scsi/msg105908.html
> which is in the stable pools with commit id:
> 96418b5e2c8867da3279d877f5d1ffabfe460c3d
This information needs to go in the tag section:
Fixes: 96418b5e2c88 ("scsi: lpfc: Fix eh_deadline setting for sli3 adapters.")
> This patch was cut against the scsi.git tree, misc branch and should
> be pulled in via the scsi tree.
>
> This patch needs to be applied to the stable trees where ever the
> introducing patch exists.
The above commentary needs to go below the --- separator.
And finally:
drivers/scsi/lpfc/lpfc_init.c: In function ?lpfc_handle_deferred_eratt?:
drivers/scsi/lpfc/lpfc_init.c:1428:3: error: ?rc? undeclared (first use in this function)
rc = lpfc_sli_chipset_init(phba);
^
drivers/scsi/lpfc/lpfc_init.c:1428:3: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/lpfc/lpfc_init.c:1430:4: warning: ?return? with a value, in function returning void [enabled by default]
return (uint64_t)-1;
^
make[3]: *** [drivers/scsi/lpfc/lpfc_init.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/scsi/lpfc] Error 2
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2
--
Martin K. Petersen Oracle Linux Engineering
WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: jsmart2021@gmail.com
Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org,
jthumshirn@suse.de, linux-nvme@lists.infradead.org,
emilne@redhat.com, Dick Kennedy <dick.kennedy@broadcom.com>,
James Smart <james.smart@broadcom.com>
Subject: Re: [PATCH v2] lpfc: Fix panic on BFS configuration.
Date: Thu, 27 Apr 2017 12:22:47 -0400 [thread overview]
Message-ID: <yq1efwd95wo.fsf@oracle.com> (raw)
In-Reply-To: <20170426191926.6061-1-jsmart2021@gmail.com> (jsmart's message of "Wed, 26 Apr 2017 12:19:26 -0700")
James,
Please run checkpatch on your submissions.
> This issue was introduced by this patch:
> http://www.spinics.net/lists/linux-scsi/msg105908.html
> which is in the stable pools with commit id:
> 96418b5e2c8867da3279d877f5d1ffabfe460c3d
This information needs to go in the tag section:
Fixes: 96418b5e2c88 ("scsi: lpfc: Fix eh_deadline setting for sli3 adapters.")
> This patch was cut against the scsi.git tree, misc branch and should
> be pulled in via the scsi tree.
>
> This patch needs to be applied to the stable trees where ever the
> introducing patch exists.
The above commentary needs to go below the --- separator.
And finally:
drivers/scsi/lpfc/lpfc_init.c: In function ‘lpfc_handle_deferred_eratt’:
drivers/scsi/lpfc/lpfc_init.c:1428:3: error: ‘rc’ undeclared (first use in this function)
rc = lpfc_sli_chipset_init(phba);
^
drivers/scsi/lpfc/lpfc_init.c:1428:3: note: each undeclared identifier is reported only once for each function it appears in
drivers/scsi/lpfc/lpfc_init.c:1430:4: warning: ‘return’ with a value, in function returning void [enabled by default]
return (uint64_t)-1;
^
make[3]: *** [drivers/scsi/lpfc/lpfc_init.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/scsi/lpfc] Error 2
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-04-27 16:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 19:19 [PATCH v2] lpfc: Fix panic on BFS configuration jsmart2021
2017-04-26 19:19 ` jsmart2021
2017-04-26 21:39 ` Laurence Oberman
2017-04-26 21:39 ` Laurence Oberman
2017-04-27 13:18 ` Ewan D. Milne
2017-04-27 13:18 ` Ewan D. Milne
2017-04-27 16:14 ` Ewan D. Milne
2017-04-27 16:14 ` Ewan D. Milne
2017-04-27 16:27 ` James Smart
2017-04-27 16:27 ` James Smart
2017-04-27 16:22 ` Martin K. Petersen [this message]
2017-04-27 16:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1efwd95wo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.