From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: AlexChen <alex.chen@huawei.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, zhengchuan@huawei.com,
jiangyiwen@huawei.com, robin.yb@huawei.com
Subject: Re: [PATCH] scsi: sd: provide a new module parameter to set whether SCSI disks support WRITE_SAME_16 by default
Date: Mon, 20 Jan 2020 19:01:06 -0500 [thread overview]
Message-ID: <yq1ftg9k799.fsf@oracle.com> (raw)
In-Reply-To: <c3c8c949-b557-1e34-5143-7a0b348a609e@acm.org> (Bart Van Assche's message of "Sun, 19 Jan 2020 11:36:17 -0800")
Bart,
>> + if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, WRITE_SAME_16) == 1 ||
>> + sd_default_support_ws16)
>> sdkp->ws16 = 1;
>>
>> if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, WRITE_SAME) == 1)
>
> Should this be fixed using the quirk mechanism instead of introducing a
> new kernel module parameter? Kernel module parameters apply to all SCSI
> disk devices irrespective of their vendor and model. The quirk mechanism
> can be used to introduce special behavior for certain disk models and
> types.
Yes, this should definitely be a blacklist option. Although I'd
obviously encourage the vendor to implement RSOC instead of working
around this in the kernel.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2020-01-21 0:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 14:13 [PATCH] scsi: sd: provide a new module parameter to set whether SCSI disks support WRITE_SAME_16 by default AlexChen
2020-01-19 19:36 ` Bart Van Assche
2020-01-20 7:32 ` AlexChen
2020-01-21 0:01 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ftg9k799.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=alex.chen@huawei.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=jiangyiwen@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=robin.yb@huawei.com \
--cc=zhengchuan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.