From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
Bart.VanAssche@wdc.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V4] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert
Date: Tue, 06 Mar 2018 21:16:51 -0500 [thread overview]
Message-ID: <yq1fu5cpr3g.fsf@oracle.com> (raw)
In-Reply-To: <1520042049-8874-1-git-send-email-jianchao.w.wang@oracle.com> (Jianchao Wang's message of "Sat, 3 Mar 2018 09:54:09 +0800")
Jianchao,
> In scsi core, __scsi_queue_insert should just put request back on
> the queue and retry using the same command as before. However, for
> blk-mq, scsi_mq_requeue_cmd is employed here which will unprepare
> the request. To align with the semantics of __scsi_queue_insert,
> use blk_mq_requeue_request with kick_requeue_list == true and put
> the reference of scsi_device.
Applied to 4.17/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-03-07 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-03 1:54 [PATCH V4] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert Jianchao Wang
2018-03-06 14:39 ` jianchao.wang
2018-03-07 2:16 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fu5cpr3g.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=Bart.VanAssche@wdc.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.