From: martin.petersen@oracle.com (Martin K. Petersen)
Subject: [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes
Date: Thu, 14 Dec 2017 22:52:11 -0500 [thread overview]
Message-ID: <yq1fu8cmyvo.fsf@oracle.com> (raw)
In-Reply-To: <20171214204936.17793-1-jeff.lien@wdc.com> (Jeff Lien's message of "Thu, 14 Dec 2017 14:49:36 -0600")
Jeff,
> + blk_queue_logical_block_size(disk->queue, bs);
> + blk_queue_physical_block_size(ns->queue, bs);
A bit messy that you mix ns->queue and disk->queue.
> + blk_limits_io_min(&ns->queue->limits, bs);
blk_queue_io_min(foo->queue, bs);
Otherwise OK.
Reviewed-by: Martin K. Petersen <martin.petersen at oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-12-15 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 20:49 [PATCH] NVMe: Format fix when going from 4k sector size to 512 bytes Jeff Lien
2017-12-14 22:42 ` Keith Busch
2017-12-15 3:52 ` Martin K. Petersen [this message]
2017-12-15 14:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1fu8cmyvo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.